Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiDriver bad timing in linear speed mode #28

Closed
laurb9 opened this issue Oct 1, 2017 · 1 comment
Closed

MultiDriver bad timing in linear speed mode #28

laurb9 opened this issue Oct 1, 2017 · 1 comment
Milestone
1.1.3

Comments

@laurb9
Copy link
Owner

laurb9 commented Oct 1, 2017 •
edited
Loading

MultiDriver does not work well, the movements take longer than they would separately. Could be just a timing overhead issue, but it happens at very slow rpm too.

example
board: Feather M0, rpm=10, microsteps=32
both axis: 30s
single axis: 15s (so the combined move should have been 15s)
@laurb9
Copy link
Owner Author

laurb9 commented Oct 1, 2017

The problem is the use of "static" where instance variables were needed, which causes call-to-call timing info kept in nextAction() to leak across multiple driver instances.

laurb9 added a commit that referenced this issue Oct 1, 2017
@laurb9
Fix timing leaks
7479336 
timing and accel series info was reused across multiple drivers due to incorrect use of "static" (#28)
@laurb9 laurb9 added this to the 1.1.3 milestone Oct 1, 2017
@laurb9 laurb9 closed this as completed Oct 1, 2017
@floriansegginger floriansegginger mentioned this issue Dec 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.3
Development

No branches or pull requests
1 participant
@laurb9