Refactor map boreal simple r #66
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I have created this draft PR to track the progress on refactoring of the mapBoreal_simple.R.
So far, the expansion around the growing season logic has been partitioned into smaller functions. Would be great to get your feedback, specially to make sure the logic has been refactored as intended.
Also, a basic test suite has been added to make sure any updates to the algorithms go through the tests before merge. So far the test coverage is pretty minimal and covers only the bits that I just added, but this hopefully will grow to the whole lib directory and then to the full repository. My hope is to setup CI/CD for the repository to do automated testing when PRs are submitted.
As a standard dev practice, it'd be good to requires all PRs to go through review and approval before being merged into the main branch.
I will keep working on this branch and try to keep the diffs small so it's easy to see what's being updated.
Best,
-Ali