Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend improvements. #79

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Frontend improvements. #79

merged 3 commits into from
Sep 11, 2024

Conversation

iberdinsky-skilld
Copy link
Contributor

@iberdinsky-skilld iberdinsky-skilld commented Jul 31, 2024

Closes #67

vars.yaml in root directory

plasmactl_web_ui_platform_name: 'Custom Platform Name'
plasmactl_web_ui_platform_favicon:
  '<svg width="300" height="130" xmlns="http://www.w3.org/2000/svg">
    <rect width="200" height="100" x="10" y="10" rx="20" ry="20" fill="blue" />
  </svg>'
plasmactl_web_ui_platform_logo:
  '<svg width="300" height="130" xmlns="http://www.w3.org/2000/svg">
    <rect width="200" height="100" x="10" y="10" rx="20" ry="20" fill="blue" />
  </svg>'

@davidferlay
Copy link
Contributor

davidferlay commented Aug 27, 2024

image

  1. Platform name: ok // However let's change default value from Platform name to Platform
  2. Tab name: could be defined in new var plasmactl_web_ui_platform_page_name
  3. Header name: could be defined in new var plasmactl_web_ui_platform_header_name
  4. Favicon: ok
  5. Header logo: not ok although correct data is present in endpoint

Also, enpoint seem to be empty when plugin is compiled in new launchrctl binary with other plugins

@davidferlay
Copy link
Contributor

davidferlay commented Sep 5, 2024

  • 4/5 solved in incognito window -> wrong usage for plasmactl_web_ui_platform_header_name
    image

  • Issue in relative/aboslute binary path:

    • ./plasmactlui web --foreground --swagger-ui > data ok
    • plasmactlui web --foreground --swagger-ui > data empty
      image

@iberdinsky-skilld
Copy link
Contributor Author

iberdinsky-skilld commented Sep 9, 2024

Moved backend issue relative/aboslute binary path to own ticket

#85

@iberdinsky-skilld iberdinsky-skilld merged commit 5c3dfbb into main Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend improvements
2 participants