(bug-fix) Update modules to accept new API header #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hashicorp [recently added a Release API](https://www.hashicorp.com/blog/announcing-the-hashicorp-releases-api) that includes a new `Content-Type` header `application/vnd+hashicorp.releases-api.v0+json`. This gets used somewhere in making requests, but the `hc-install` Go library was previously at version 0.3.1 which raised an error when it encountered this header. V0.3.2 accepts the header, so this updates the Go modules in this repo using `go get -u && go mod tidy`.
|
Honestly kind of unclear to me if this will just get magically fixed in CI and I don't need to do this? |
Yeah this terraform SDK version update should fix it based on what I can tell from their release notes for 2.16.0. The latest |
|
Opened a PR against the private repo hashicorp/terraform-plugin-sdk@f74b5a6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hashicorp recently added a Release
API
that includes a new
Content-Typeheaderapplication/vnd+hashicorp.releases-api.v0+json. This gets usedsomewhere in making requests, but the
hc-installGo library waspreviously at version 0.3.1 which raised an error when it encountered
this header. V0.3.2 accepts the header, so this updates the Go modules
in this repo using
go get -u && go mod tidy.