Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set up goreleaser #225

Merged
merged 4 commits into from
Dec 4, 2024
Merged

chore: set up goreleaser #225

merged 4 commits into from
Dec 4, 2024

Conversation

sloloris
Copy link
Member

@sloloris sloloris commented Dec 4, 2024 •
edited
Loading

This should set up the necessary release.yml and .goreleaser.yml files to push to the Terraform registry once we've tagged a new version.

ldhenry
ldhenry requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@ldhenry ldhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also need to update the .goreleaser.yml file to be similar to the example one here.

I think we will also need to add a terraform-registry-manifest.json file as well.

@sloloris sloloris requested a review from ldhenry December 4, 2024 15:57
@ldhenry ldhenry marked this pull request as ready for review December 4, 2024 16:11
@ldhenry ldhenry requested a review from a team as a code owner December 4, 2024 16:11
ldhenry
ldhenry approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@ldhenry ldhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me though you'll need to pull main again and update the PR title.

@sloloris sloloris changed the title add release.yml chore: set up goreleaser Dec 4, 2024
@sloloris sloloris merged commit 542ca45 into main Dec 4, 2024
4 checks passed
@sloloris sloloris deleted the imiller/REL-4482/add-github-release-workflow branch December 4, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldhenry ldhenry ldhenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sloloris @ldhenry