update page title to adhere to what crossplane expects #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldhenry
requested changes
Aug 25, 2023
There was a problem hiding this comment.
Hey @felixlut, our docs (including page_titles) were recently updated so that they are generated from the resource schema using Hashicorp's terraform-plugin-docs. This is an approach recommended by Hashicorp and taken by our peers, such as Datadog and JFrog, and is likely something that more and more providers will switch to in the future. For that reason, I don't recommend making this change. Likely Upjet will need to make an adjustment to how they consume these docs.
|
@ldhenry Aight, thanks for the quick feedback. I'll check how it looks on that side instead! |
|
Turns out that the latest release of upjet 4 days ago resolves this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the title to adhere to what Upjet expects.
Related to #170