chore: Update configuration language to match new data system #267
Conversation
|
Definitely want to review this one commit at a time. |
| "github.com/launchdarkly/sdk-test-harness/v2/servicedef" | ||
| ) | ||
|
|
||
| type sdkDataSystemSourceConfig struct { |
There was a problem hiding this comment.
I think it might make sense to call it DataSystemConfig, and DataSystemOptionPolling etc without the "Source" part.
| )...) | ||
|
|
||
| request := dataSource.Endpoint().RequireConnection(t, time.Second) | ||
| request := dataSystem.Synchronizers.primary.Endpoint().RequireConnection(t, time.Second) |
There was a problem hiding this comment.
Wondering if it'd make sense to add a .PrimarySync() or .Synchronizer() helper that pulls out the primary. That way, the bulk of the existing tests that don't care about the existence of a secondary don't need to really know about it
sdktests/common_tests_stream_base.go
Outdated
| // creating an SDK client. | ||
| // | ||
| // This behavior differs between SDK types as follows: | ||
| // | ||
| // - Server-side SDKs in streaming mode use *only* the streaming service. | ||
| // - Server-side SDKs in streaming mode use *only* the streaming synchronizing service. |
There was a problem hiding this comment.
Think it's fair to keep this as streaming service, since synchronizer is a name to describe the general class of thing
sdktests/common_tests_stream_fdv2.go
Outdated
| stream.streamingService.PushUpdate("flag", "flag-key", 2, c.makeFlagData("flag-key", 2, updatedValue)) | ||
| stream.streamingService.PushHeartbeat() | ||
| stream.streamingService.PushPayloadTransferred("updated", 2) | ||
| dataSystem.Synchronizers.primary.streamingService.PushHeartbeat() |
There was a problem hiding this comment.
Yea I think having a helper would definitely make this easier to deal with
No description provided.