feat: add http proxy test for client-side polling #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
commented
Nov 18, 2024
| @@ -22,7 +23,9 @@ func doClientSideStreamRequestTest(t *ldtest.T) { | |||
| streamTests := NewCommonStreamingTests(t, "doClientSideStreamRequestTest", | |||
| WithCredential(envIDOrMobileKey)) | |||
|
|
|||
| streamTests.RequestViaHTTPProxy(t) | |||
There was a problem hiding this comment.
Just hoisting the capability check upwards, as is the pattern. Well, a pattern. Other tests put the check directly in the test 🤷♂️
cwaldren-ld
changed the title
cwaldren-ld
force-pushed
the
cw/sdk-891-polling-http-proxy
branch
from
3ba5253 to
0c4dbfa
Compare
kinyoklion
approved these changes
Nov 19, 2024
cwaldren-ld
pushed a commit
that referenced
this pull request
Nov 19, 2024
🤖 I have created a release *beep* *boop* --- ## [2.27.0](v2.26.0...v2.27.0) (2024-11-19) ### Features * add http proxy test for client-side events ([#265](#265)) ([dfec55f](dfec55f)) * add http proxy test for client-side polling ([#264](#264)) ([1ef3bc2](1ef3bc2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.