chore: Introduce DataSystem configuration #259
Conversation
All tests passing except: * evaluation/parameterized/prerequisites/prerequisite cycle is detected at top level, recursion stops/prerequisite cycle is detected at top level, recursion stops/evaluate flag without detail * evaluation/parameterized/prerequisites/prerequisite cycle is detected at top level, recursion stops/prerequisite cycle is detected at top level, recursion stops/evaluate flag with detail * evaluation/parameterized/prerequisites/prerequisite cycle is detected at deeper level, recursion stops/prerequisite cycle is detected at deeper level, recursion stops/evaluate flag without detail * evaluation/parameterized/prerequisites/prerequisite cycle is detected at deeper level, recursion stops/prerequisite cycle is detected at deeper level, recursion stops/evaluate flag with detail * streaming/fdv2/reconnection state management/saves previously known state * streaming/fdv2/reconnection state management/replaces previously known state * streaming/fdv2/reconnection state management/updates previously known state * streaming/fdv2/ignores model version * streaming/fdv2/disconnects on goodbye * polling/requests/method and headers/GET/http * polling/requests/URL path is computed correctly/no environment filter/base URI has no trailing slash/GET * polling/requests/URL path is computed correctly/no environment filter/base URI has a trailing slash/GET * polling/requests/URL path is computed correctly/environment_filter_key="encoding_not_necessary"/base URI has no trailing slash/GET * polling/requests/URL path is computed correctly/environment_filter_key="encoding_not_necessary"/base URI has a trailing slash/GET * polling/requests/URL path is computed correctly/environment_filter_key="encoding necessary +! %& ( )"/base URI has no trailing slash/GET * polling/requests/URL path is computed correctly/environment_filter_key="encoding necessary +! %& ( )"/base URI has a trailing slash/GET * polling/payload/large payloads * service endpoints/using separate service endpoints properties/streaming
| @@ -12,7 +12,6 @@ import ( | |||
|
|
|||
| func doClientSideStreamTests(t *ldtest.T) { | |||
| t.Run("requests", doClientSideStreamRequestTest) | |||
| t.Run("updates", doClientSideStreamUpdateTests) | |||
There was a problem hiding this comment.
I removed these update tests from the client and server tests because they don't make sense in the fdv2 work.
Originally these tests were making sure we handled individual flag / segment version values appropriately when updating the in memory store. That doesn't matter anymore (we strictly go off payload version), so we don't need this.
A subsequent commit will bring back something similar when we start interacting with the data stores. But they won't be written this like I would hope.
--
This deletion goes until the next comment.
| func doServerSideStreamUpdateTests(t *ldtest.T) { | ||
| NewCommonStreamingTests(t, "doServerSideStreamUpdateTests").Updates(t) | ||
| } | ||
|
|
| @@ -77,7 +77,14 @@ func WithEventsConfig(eventsConfig servicedef.SDKConfigEventParams) SDKConfigure | |||
| // WithPollingConfig is used with StartSDKClient to specify a non-default polling configuration. | |||
| func WithPollingConfig(pollingConfig servicedef.SDKConfigPollingParams) SDKConfigurer { | |||
| return helpers.ConfigOptionFunc[servicedef.SDKConfigParams](func(configOut *servicedef.SDKConfigParams) error { | |||
| configOut.Polling = o.Some(pollingConfig) | |||
| dataSystem := configOut.DataSystem.OrElse(servicedef.DataSystem{}) | |||
There was a problem hiding this comment.
For FDv1 support, it is assumed that there is only ever polling or streaming. So we can safely assume, for this first iteration, that these must be equivalent to the primary synchronizer of FDV2 fame.
Subsequent commits will rename these methods to be like WithPrimaryPolling or something of that nature. Letting that evolve as I refactor.
| newState := config.Streaming.Value() | ||
| newState.BaseURI = d.endpoint.BaseURL() | ||
| config.Streaming = o.Some(newState) | ||
| dataSystem := config.DataSystem.OrElse(servicedef.DataSystem{}) |
There was a problem hiding this comment.
Ridiculous unpacking and re-assignment we discussed over Slack.
| @@ -237,8 +237,8 @@ func (b *ServerSDKDataBuilder) BuildServerSDKData() ServerSDKData { | |||
| segments := maps.Clone(b.segments) | |||
|
|
|||
| return map[DataItemKind]map[string]json.RawMessage{ | |||
| "flags": flags, | |||
| "segments": segments, | |||
| "flag": flags, | |||
There was a problem hiding this comment.
In fdv1, that key was used as the data kind that was receiving the put object. It is still used that way in fdv2, but those keys are not pluralized.
This commit introduces the concept of the data system configuration. In addition, all existing polling and streaming configurations have been updated to be expressed in terms of primary synchronizers.
As it currently stands, most of the tests are passing. There are a handful that fail which I believe are expected. Even so, this is going into a feature branch, so I'm not too concerned about the failures just yet.