chore: Introduce opt-in flag to enable persistence support #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
mk/sdk-812/refactor
to
feat/persistence-tests
October 25, 2024 15:42
kinyoklion
reviewed
Oct 25, 2024
kinyoklion
approved these changes
Oct 25, 2024
keelerm84
added a commit
that referenced
this pull request
Oct 31, 2024
The SDK test harness has historically been self-sufficient. With the introduction of persistence-based unit tests, that is no longer the case. Externally started services are required for each persistence technology supported. Since we want to retain the ease of use associated with a our current `go run .` usage, we are going to disable persistence support by default. Users will have to provide a `-enable-persistence-tests` if they want the test harness to attempt those tests. SDKs under test are still required to provide the appropriate capabilities. In the event those capabilities are provided, but the test harness flag is not provided, persistence tests will be skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK test harness has historically been self-sufficient. With the introduction of persistence-based unit tests, that is no longer the case. Externally started services are required for each persistence technology supported.
Since we want to retain the ease of use associated with a our current
go run .usage, we are going to disable persistence support by default. Users will have to provide a-enable-persistence-testsif they want the test harness to attempt those tests.SDKs under test are still required to provide the appropriate capabilities. In the event those capabilities are provided, but the test harness flag is not provided, persistence tests will be skipped.