cleanup

framework/harness/harness.go

@@ -32,6 +32,7 @@ type TestHarness struct {
 	https bool
 }
 
+// SetHTTPS tells the test harness to generate HTTPS endpoints when NewMockEndpoint is called.
 func (h *TestHarness) SetHTTPS(https bool) {
 	h.https = https
 }

framework/harness/mock_endpoints.go

@@ -230,7 +230,7 @@ func (m *mockEndpointsManager) serveHTTP(w http.ResponseWriter, r *http.Request)
 	e.lock.Unlock()
 }
 
-// BaseURL returns the base path of the mock endpoint using http transport and port.
+// BaseURL returns the base path of the mock endpoint.
 func (e *MockEndpoint) BaseURL() string {
 	return e.owner.externalBaseURL + e.basePath
 }

framework/ldtest/test_scope.go

@@ -43,11 +43,6 @@ type TestConfiguration struct {
 	Capabilities []string
 }
 
-func (t TestConfiguration) WithContext(context interface{}) TestConfiguration {
-	t.Context = context
-	return t
-}
-
 // Run starts a top-level test scope.
 func Run(
 	config TestConfiguration,

framework/opt/maybe.go

@@ -42,14 +42,6 @@ func (m Maybe[V]) AsPtr() *V {
 	return nil
 }
 
-// Map transforms the value using the given function if it exists, or returns None if it doesn't.
-func (m Maybe[V]) Map(f func(V) V) Maybe[V] {
-	if m.defined {
-		return Some(f(m.value))
-	}
-	return None[V]()
-}
-
 // OrElse returns the value of the Maybe if any, or the valueIfUndefined otherwise.
 func (m Maybe[V]) OrElse(valueIfUndefined V) V {
 	if m.defined {

params.go

@@ -26,7 +26,8 @@ func (c *commandParams) Read(args []string) bool {
 	fs := flag.NewFlagSet("", flag.ExitOnError)
 	fs.StringVar(&c.serviceURL, "url", "", "test service URL")
 	fs.StringVar(&c.host, "host", "localhost", "external hostname of the test harness")
-	fs.IntVar(&c.port, "port", defaultPort, "http port that the test harness will listen on")
+	fs.IntVar(&c.port, "port", defaultPort, "http port that the test harness will listen on"+
+		" (if TLS capability enabled in an SDK, then port+1 will be used for HTTPS)")
 	fs.Var(&c.filters.MustMatch, "run", "regex pattern(s) to select tests to run")
 	fs.Var(&c.filters.MustNotMatch, "skip", "regex pattern(s) to select tests not to run")
 	fs.BoolVar(&c.stopServiceAtEnd, "stop-service-at-end", false, "tell test service to exit after the test run")

sdktests/common_tests_poll_request.go

@@ -38,7 +38,8 @@ func (c CommonPollingTests) RequestMethodAndHeaders(t *ldtest.T, credential stri
 						m.In(t).For("request method").Assert(request.Method, m.Equal(string(method)))
 						m.In(t).For("request headers").Assert(request.Headers, c.authorizationHeaderMatcher(credential))
 						if t.Capabilities().Has(servicedef.CapabilityPollingGzip) {
-							m.In(t).For("request headers").Assert(request.Headers, Header("Accept-Encoding").Should(m.StringContains("gzip")))
+							m.In(t).For("request headers").Assert(request.Headers,
+								Header("Accept-Encoding").Should(m.StringContains("gzip")))
 						}
 					})
 				}

servicedef/sdk_config.go

@@ -28,8 +28,7 @@ type SDKConfigParams struct {
 }
 
 type SDKConfigTLSParams struct {
-	VerifyPeer               bool   `json:"verifyPeer,omitempty"`
-	CertificateAuthorityPath string `json:"certificateAuthorityPath,omitempty"`
+	VerifyPeer bool `json:"verifyPeer,omitempty"`
 }
 type SDKConfigServiceEndpointsParams struct {
 	Streaming string `json:"streaming,omitempty"`