chore: remove deprecated tslint dependency #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove tslint dependency from root package.json - remove tslint-disable-next-line statements from various files - add pnpm-lock.yaml and pnpm-debug.log files to .gitignore
mcmxcdev
commented
Oct 31, 2024
| @@ -12,5 +13,6 @@ test-types.js | |||
| docs/build/ | |||
| yarn.lock | |||
| package-lock.json | |||
| pnpm-lock.yaml | |||
There was a problem hiding this comment.
NPM and Yarn specific files were gitignored already but PNPM was not so far.
kinyoklion
reviewed
Nov 1, 2024
| @@ -78,7 +78,7 @@ | |||
| "rollup-plugin-dts": "^6.1.0", | |||
| "rollup-plugin-esbuild": "^6.1.1", | |||
| "ts-jest": "^29.2.2", | |||
| "tslint": "^6.1.3", | |||
| "tslib": "^2.8.1", | |||
There was a problem hiding this comment.
The build was indirectly depending on tslib, and removing tslint make it so it could not build.
kinyoklion
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Changes
tslintdependency from rootpackage.jsontslint-disable-next-linestatements from various filespnpm-lock.yamlandpnpm-debug.logfiles to.gitignoreRelated issues
When running dependency installation with e.g.
pnpmin this repository, I encountered the following warning:The migration from
tslinttoeslintwas done in #297, but it seems that thetslintdependency has not been removed as part of it.