Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate uwsgi enable-threads error logging #84

Closed
dougkeen opened this issue May 22, 2018 · 2 comments
Closed

Inaccurate uwsgi enable-threads error logging #84

dougkeen opened this issue May 22, 2018 · 2 comments

Comments

@dougkeen
Copy link

Right now, if you run the client in a uwsgi environment without the enable-threads option set, this message gets error logged:

The LaunchDarkly client requires the enable-threads option be passed to uWSGI.

However, the uwsgi config could not have enable-threads explicitly set, but rather have threads implicitly enabled by setting a threads option.

By default the Python plugin does not initialize the GIL. This means your app-generated threads will not run. If you need threads, remember to enable them with enable-threads. Running uWSGI in multithreading mode (with the threads options) will automatically enable threading support. This “strange” default behaviour is for performance reasons, no shame in that.

In the case where enable-threads is not specified in the uwsgi config, but threads is, the LaunchDarkly client will incorrectly log the above error message.

@eli-darkly
Copy link
Contributor

Thanks. This seems like a straightforward change. I'm currently working on setting up a test environment for it, so we can make sure we're reading the options correctly.

@eli-darkly
Copy link
Contributor

Fixed in version 6.0.2.

eli-darkly added a commit that referenced this issue Jan 31, 2019
add Consul feature store integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants