-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install broken on pip 10.x #80
Comments
Struggling with the same issue here, would need this fixed. |
Same here. Please fix :) |
Same issue. Needs work for PIP 10.
|
I'll try to fix it later tonight if I have time and open a PR So I don't forget: def parse_requirements(filename):
""" load requirements from a pip requirements file """
lineiter = (line.strip() for line in open(filename))
return [line for line in lineiter if line and not line.startswith("#")] |
Starting in pip 10.x, parse_requirements was moved to an internal namespace to help demonstrate the fact that it is not a public API. As a workaround until a broader decision can be made about how this should look long term, this change attepts to perform the import using the pip 10.x path and if it fails, falls back on the older path. Fixes launchdarkly#80.
Any workarounds in the meantime? Downgrading pip? |
Sorry about this. We'll be putting out a patch release to fix it today— probably will go with implementing the function ourselves as @theholy7 suggested, rather than importing the non-public API which could just get us in trouble again in the future. (Also in the meantime, downgrading pip is the only workaround as far as I know.) |
@eli-darkly - Just submitted a PR - hopefully it follows your standards :) |
|
…port add feature store wrapper class and make Redis feature store use it
From the pip CHANGELOG:
The text was updated successfully, but these errors were encountered: