-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RedisFeatureStore does not offer ssl_ca_certs kwarg #159
Comments
cn-alexboyd
changed the title
RedisFeatureStore does not support encrypted connections
RedisFeatureStore does not offer ssl_ca_certs kwarg
Aug 20, 2021
At first glance that seems like a reasonable and straightforward enhancement. It's hard for us to cover this in automated testing, so we would have to trust that the behavior of the |
LaunchDarklyReleaseBot
pushed a commit
that referenced
this issue
Feb 16, 2022
Test Data Source Documentation + Refactor + Additional Tests
SSL-related and other Redis connection options can be easily set directly in the URL, for example: qs = urllib.parse.urlencode({
"ssl_cert_reqs": "required",
"ssl_ca_certs": "/absolute/path/to/ca.crt",
"ssl_keyfile": "/absolute/path/to/client.key",
"ssl_certfile": "/absolute/path/to/client.crt",
})
store = Redis.new_feature_store(f'rediss://:password@host:port/0?{qs}') |
Fixed in 7.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
I would love for the RedisFeatureStore to allow for me to specify a host, port, password, SSL, and ssl_ca_cert if applicable when trying to connect to a Redis cluster that has TLS/SSL enabled.
Describe the solution you'd like
Ideally, I could use the existing
RedisFeatureStore.new_feature_store()
method with a new set of kwargs instead of just the connection url.Describe alternatives you've considered
The required redis package already supports these args, I think the adjustment will be using something other than
redis.ConnectionPool.from_url
during initialization of _RedisFeatureStoreCore.The text was updated successfully, but these errors were encountered: