This repository has been archived by the owner on May 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns, fix LDFeatureStore.close return value
…hods-to-typescript-definitions [ch20232] Add flag util methods to typescript definitions
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/npm:cryptiles:20180710
[Snyk] Fix for 1 vulnerable dependencies
remove npm dependency on "crypto", use built-in version instead
treat HTTP 400 as a recoverable error
# Conflicts: # package-lock.json
update doc comment for new waitForInitialization behavior
fix waitForInitialization to always resolve with a value
Update LDFeatureStore type definition for versioned data kind
add new version of allFlags() that captures more metadata
fix "npm audit" warnings
# Conflicts: # package-lock.json
bump jest version to stop vulnerability warning
fix track() and identify() to reject missing/keyless user
# Conflicts: # package-lock.json
stop file data source from doing unnecessary reloads
many TS doc fixes and TypeDoc build script
apucacao
approved these changes
Feb 22, 2019
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Aug 20, 2019
update doc comment for track() with metricValue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[5.7.2] - 2019-02-22
Fixed:
identify()
ortrack()
with no user object, or with a user that has no key, will now cause the SDK to log a warning (as the other SDKs do). The SDK no longer sends an analytics event in this case, since LaunchDarkly would discard the event as invalid anyway. Also, previously, callingidentify()
with no user object would throw an exception.FileDataSource
, in auto-update mode, could sometimes reload files more than once when they were only modified once (due to a known issue with Node'sfs.watch
). This should no longer happen. (#138)npm audit
. These were all for test-only dependencies, so would not affect production code.privateAttributeNames
, was not usable from TypeScript because it was omitted from the TypeScript declarations.type
now useinterface
instead, except forLDFlagValue
which is a type alias. This should not affect regular usage of the SDK in TypeScript, but it is easier to extend aninterface
than atype
if desired.