Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

"yaml" dependency breaks compatibility with older node versions #144

Closed
repl-sean-heintz opened this issue Feb 28, 2019 · 2 comments
Closed

Comments

@repl-sean-heintz
Copy link

ldclient version: 5.7.2
node version: 5.12.0

Error encountered:

/opt/app/node_modules/yaml/dist/cst/ParseContext.js:83
  constructor(orig = {}, {
                   ^

SyntaxError: Unexpected token =
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:387:25)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/opt/app/node_modules/yaml/dist/cst/parse.js:10:44)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/opt/app/node_modules/yaml/dist/index.js:8:37)
    at Module._compile (module.js:413:34)

The package specifies that ldclient-node is compatible with:

  "engines": {
    "node": ">= 0.8.x"
  }

Can you please either fix the compatibility with older versions, or update the engine requirements?

Thanks!

@eli-darkly
Copy link
Contributor

Sorry for the confusion - we do need to update the engines property, it is out of date. We currently don't support any Node version lower than 6.x, as the README.md states.

@repl-sean-heintz
Copy link
Author

Thanks Eli, closing this.

LaunchDarklyCI pushed a commit that referenced this issue Oct 23, 2019
reimplement flag change events to use dependency graph
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants