Modify the archive manager so that atomic updates of the configuration archive work correctly. #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @gmckerrell, thank you for your contribution and explanation. We will test the change and will update you after that. Filed internally as 228550. |
|
Hi @gmckerrell, thanks again. I will merge this now and the next Relay v7/v8 releases should have the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
#280
Describe the solution you've provided
Rather than use
nsnotifyto watch the explicit configuration file, we monitor the parent directory which means both slow-copy and atomic update semantics both work as expected.Describe alternatives you've considered
In our current use case we have deferred to slow-copy semantics rather than atomic updates.