Update metrics.md #135
Merged
Update metrics.md #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correcting broken documentation link
eli-darkly
suggested changes
Apr 23, 2021
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| [(Back to README)](../README.md) | |||
|
|
|||
| You can configure the Relay Proxy to export statistics and route traces to Datadog, Stackdriver, and Prometheus. To learn about the available settings for each of these options, read [Configuration](./docs/configuration.md). | |||
| You can configure the Relay Proxy to export statistics and route traces to Datadog, Stackdriver, and Prometheus. To learn about the available settings for each of these options, read [Configuration](../configuration.md). | |||
There was a problem hiding this comment.
Thanks for noticing the broken link, but your replacement link is also broken: configuration.md is in the same directory as metrics.md, so this should be a single period and not a double one.
|
We're getting ready to do a Relay Proxy bugfix release, so I'm going to go ahead and merge this PR into a branch so that I can fix the remaining problem that I commented on and get the change into the release. |
eli-darkly
approved these changes
Apr 23, 2021
Merged
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Apr 23, 2021
(v6 - #3) big refactoring of Relay tests
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correcting broken documentation link
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.