chore: Prepare for browser client releases. #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Oct 9, 2024
| @@ -1,4 +1,4 @@ | |||
| import { init, LDClient, LDLogger, LDOptions } from '@launchdarkly/js-client-sdk'; | |||
| import { initialize, LDClient, LDLogger, LDOptions } from '@launchdarkly/js-client-sdk'; | |||
There was a problem hiding this comment.
Changed the name to match existing package.
It means client/server are not consistent, so we may want to add init to the client, or add initialize to the server, then mark as deprecated.
kinyoklion
commented
Oct 9, 2024
| @@ -31,16 +31,19 @@ import BrowserPlatform from './platform/BrowserPlatform'; | |||
| * Applications should configure the client at page load time and reuse the same instance. | |||
| * | |||
| * For more information, see the [SDK Reference Guide](https://docs.launchdarkly.com/sdk/client-side/javascript). | |||
| * | |||
| * @ignore Implementation Note: We are not supporting dynamically setting the connection mode on the LDClient. | |||
There was a problem hiding this comment.
This caused the entire type not to be in the docs. Moved these implementation notes.
kinyoklion
commented
Oct 9, 2024
| @@ -2,8 +2,6 @@ | |||
| import './style.css'; | |||
| import TestHarnessWebSocket from './TestHarnessWebSocket'; | |||
|
|
|||
| // const client = init('618959580d89aa15579acf1d', AutoEnvAttributes.Enabled); | |||
There was a problem hiding this comment.
Forgot this at some point. Ok though client-side IDs are not secret.
tanderson-ld
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.