-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Prepare for browser client releases. #612
Conversation
@@ -1,4 +1,4 @@ | |||
import { init, LDClient, LDLogger, LDOptions } from '@launchdarkly/js-client-sdk'; | |||
import { initialize, LDClient, LDLogger, LDOptions } from '@launchdarkly/js-client-sdk'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the name to match existing package.
It means client/server are not consistent, so we may want to add init to the client, or add initialize to the server, then mark as deprecated.
@@ -31,16 +31,19 @@ import BrowserPlatform from './platform/BrowserPlatform'; | |||
* Applications should configure the client at page load time and reuse the same instance. | |||
* | |||
* For more information, see the [SDK Reference Guide](https://docs.launchdarkly.com/sdk/client-side/javascript). | |||
* | |||
* @ignore Implementation Note: We are not supporting dynamically setting the connection mode on the LDClient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This caused the entire type not to be in the docs. Moved these implementation notes.
@@ -2,8 +2,6 @@ | |||
import './style.css'; | |||
import TestHarnessWebSocket from './TestHarnessWebSocket'; | |||
|
|||
// const client = init('618959580d89aa15579acf1d', AutoEnvAttributes.Enabled); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot this at some point. Ok though client-side IDs are not secret.
No description provided.