feat: Implement jest mocks for react-native. #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so added 6 levels to workspace root of metro.config.js
… find-yarn-workspace-root and index.js to jest example to fix monorepo issues, added @launchdarkly/jest/react-native to App.tsx and welcome.tsx
…nvironment in react-native jest to jsdom
kinyoklion
changed the title
kinyoklion
reviewed
Aug 6, 2024
| import { mockFlags, mockUseLDClient } from '@launchdarkly/jest/react-native'; | ||
|
|
||
| export default function Welcome() { | ||
| const flagValue = mockFlags({ 'dev-test-flag': true }); |
There was a problem hiding this comment.
I think that we probably want the example to appear like a normal react-native application using our SDK, then have tests that use a component from that application, but with a mock?
Similar to the example tests in the existing mocks project: https://github.com/launchdarkly/jest-launchdarkly-mock
…re like a normal react app that just mocks flags
… react app that just mocks flags
…to de-mock it after a conversation with Ryan.
professorice
force-pushed
the
mzafir/react-native-jest-mock
branch
from
8b05e27
to
4dc3bf2
Compare
…s work properly using welcome.tsx
kinyoklion
reviewed
Oct 28, 2024
kinyoklion
requested changes
Oct 28, 2024
| alignItems: 'center', | ||
| justifyContent: 'center', | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Please add a newline to the end of this file.
There was a problem hiding this comment.
Looks like there are some other files. So just double check.
You should see the angry symbol at the bottom in the diffs.
packages/tooling/jest/package.json
Outdated
| "rimraf": "^5.0.1", | ||
| "ts-jest": "^29.1.0", | ||
| "typedoc": "0.25.0", | ||
| "typescript": "5.1.6" | ||
| }, | ||
| "dependencies": { | ||
| "@launchdarkly/react-native-client-sdk": "workspace:^", |
There was a problem hiding this comment.
I think we need the version from the package here. Otherwise funky things will happen when this is published.
kinyoklion
approved these changes
Oct 28, 2024
kinyoklion
reviewed
Oct 28, 2024
kinyoklion
reviewed
Oct 28, 2024
…e not being used and were causing an issue. Also added addHook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.