chore: refactored fetch to use Platform.requests. Removed jest-fetch-mock. #297

yusinto · 2023-10-10T00:02:39Z

No description provided.

…mock and manually mock fetch responses.

shortcut-integration · 2023-10-10T00:02:42Z

packages/shared/sdk-client/package.json

packages/shared/sdk-client/src/evaluation/fetchFlags.ts

yusinto · 2023-10-10T17:24:19Z

packages/shared/mocks/src/mockFetch.ts

@kinyoklion please re-review I have improved the mockFetch implementation so it's easier to use. Thank you.

chore: refactored fetch to use Platform.requests. Removed jest-fetch-…

891e0b8

…mock and manually mock fetch responses.

yusinto requested review from kinyoklion and louis-launchdarkly as code owners October 10, 2023 00:02

yusinto commented Oct 10, 2023

View reviewed changes

packages/shared/sdk-client/package.json Show resolved Hide resolved

yusinto commented Oct 10, 2023

View reviewed changes

packages/shared/sdk-client/src/evaluation/fetchFlags.ts Show resolved Hide resolved

chore: remove redundant dom api comments.

1920a58

kinyoklion approved these changes Oct 10, 2023

View reviewed changes

chore: improve mockFetch implementation.

5b626cc

yusinto commented Oct 10, 2023

View reviewed changes

yusinto requested a review from kinyoklion October 10, 2023 17:24

kinyoklion approved these changes Oct 10, 2023

View reviewed changes

yusinto merged commit 67c3beb into yus/sc-219625/implement-initial-flag-fetch Oct 10, 2023
1 check passed

yusinto deleted the yus/sc-220131/refactor-fetch-to-use-platform-requests branch October 10, 2023 17:26

Provide feedback