feat: Remove custom measurements. #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
requested review from
yusinto and
louis-launchdarkly
as code owners
yusinto
reviewed
Aug 16, 2023
Comment on lines
+52
to
+54
| // Here we are protecting ourselves from JS callers. TypeScript says that | ||
| // it cannot be an empty string, but those using JS can do what they want. | ||
| // @ts-ignore |
yusinto
reviewed
Aug 16, 2023
| @@ -53,8 +44,7 @@ export interface LDMigrationErrorMeasurement { | |||
| export type LDMigrationMeasurement = | |||
| | LDMigrationLatencyMeasurement | |||
| | LDMigrationErrorMeasurement | |||
| | LDMigrationConsistencyMeasurement | |||
| | LDMigrationCustomMeasurement; | |||
There was a problem hiding this comment.
So this will break existing applications. This is ok, if the plan is for a major release?
There was a problem hiding this comment.
None of this is released. All on a feature branch.
There was a problem hiding this comment.
(If it were, then yes, this would be a major version.)
keelerm84
approved these changes
Aug 16, 2023
yusinto
approved these changes
Aug 16, 2023
kinyoklion
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.