-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove custom measurements. #243
Conversation
// Here we are protecting ourselves from JS callers. TypeScript says that | ||
// it cannot be an empty string, but those using JS can do what they want. | ||
// @ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -53,8 +44,7 @@ export interface LDMigrationErrorMeasurement { | |||
export type LDMigrationMeasurement = | |||
| LDMigrationLatencyMeasurement | |||
| LDMigrationErrorMeasurement | |||
| LDMigrationConsistencyMeasurement | |||
| LDMigrationCustomMeasurement; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this will break existing applications. This is ok, if the plan is for a major release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of this is released. All on a feature branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(If it were, then yes, this would be a major version.)
No description provided.