feat: Add custom event support to tracker. #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusinto
reviewed
Aug 3, 2023
| createEvent(): LDMigrationOpEvent | undefined { | ||
| if (this.operation && Object.keys(this.contextKeys).length) { | ||
| const measurements: LDMigrationMeasurement[] = []; | ||
| const measurements: LDMigrationMeasurement[] = [...this.customMeasurements]; |
There was a problem hiding this comment.
Suggested change
| const measurements: LDMigrationMeasurement[] = [...this.customMeasurements]; | |
| // ts should be able to infer the type automatically? | |
| // also why not just assign the array directly? | |
| const measurements = this.customMeasurements; |
There was a problem hiding this comment.
If it was assigned, and you added another custom event to the same tracker, then it would end up inside the already generated event.
Similarly if you changed the event that was generated it would contaminate the state of the tracker.
Generally it may not be used that way, but it is exposed to outside developers, so I prefer the isolation.
The type should infer now, so I can remove that part.
yusinto
reviewed
Aug 3, 2023
yusinto
approved these changes
Aug 3, 2023
Co-authored-by: Yusinto Ngadiman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.