DO NOT MERGE: feat: add the ability to send events using the Vercel Edge SDK #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #211103: Release beta version of Vercel SDK with events enabled. |
ldhenry
changed the title
ldhenry
changed the title
ldhenry
requested review from
kinyoklion,
yusinto and
louis-launchdarkly
as code owners
kinyoklion
reviewed
Jul 31, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kinyoklion
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
This LGTM, you may want to wait for a signoff from @yusinto as well. In case he has any edge specific thoughts.
ldhenry
changed the title
|
I added DO NOT MERGE to the title because we are waiting on customer feedback of the alpha package. |
…rcel-sdk-with-events
|
@ldhenry The user agent change is now merged, so you can remove the wrapper name/version. |
yusinto
reviewed
Aug 25, 2023
yusinto
requested changes
Aug 25, 2023
|
Closing in favor of #256 |
yusinto
added a commit
that referenced
this pull request
Nov 12, 2023
Edge sdks use clientSideID not sdk-key. We should be able to post events to the eventsUri/bulk/clientSideID endpoint for edge sdks without needing to specify the sdk key in the authorization header. This is an alternate solution to #217. Both prs are attempting to enable events for edge sdks. Don't be alarmed with the filecount, it's mostly shell file fixes unrelated to this to include a directive which seems to be needed for local build. --------- Co-authored-by: LaunchDarklyReleaseBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to send events using the Vercel Edge SDK. The Edge SDK requires the client-side ID to retrieve feature flags from the Vercel Edge Config, so I had to add a new option for the
serverSideKeyso we can set the correct authorization header.I have tested this locally and also published an alpha version of this branch to test in a deployed environment.