This repository has been archived by the owner on May 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(5.0) move flag change stuff into FlagTracker facade, simplify value listener
# Conflicts: # CONTRIBUTING.md
# Conflicts: # CONTRIBUTING.md
# Conflicts: # benchmarks/src/jmh/java/com/launchdarkly/client/FlagData.java # benchmarks/src/jmh/java/com/launchdarkly/client/TestValues.java # benchmarks/src/jmh/java/com/launchdarkly/sdk/server/EventProcessorBenchmarks.java # benchmarks/src/jmh/java/com/launchdarkly/sdk/server/LDClientEvaluationBenchmarks.java # benchmarks/src/jmh/java/com/launchdarkly/sdk/server/TestValues.java
# Conflicts: # benchmarks/src/jmh/java/com/launchdarkly/sdk/server/TestValues.java
…github.com:launchdarkly/java-server-sdk-private into rneal/ch101658/add-support-for-experiment-rollouts
…for-experiment-rollouts Add support for experiment rollouts
Co-authored-by: Sam Stokes <[email protected]>
…ic-for-isExperiment simlpify the logic and make it match node/.Net sdks
protect against NPEs if flag/segment JSON contains a null value
# Conflicts: # src/test/java/com/launchdarkly/sdk/server/DataModelSerializationTest.java
#289) * update to okhttp-eventsource patch for stream retry bug, improve test * add test for appropriate stream retry
* add public builder for FeatureFlagsState * javadoc fixes
# Conflicts: # src/main/java/com/launchdarkly/sdk/server/integrations/FileData.java
gwhelanLD
approved these changes
Jul 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[5.6.0] - 2021-07-02
Added:
builder()
method inFeatureFlagsState
, for creating instances of that class (most likely useful in test code). (#234)Fixed:
LDClient
constructor with an SDK key that contained a character less than0x20
or greater than0x7e
, it would throw anIllegalArgumentException
that contained the full SDK key string in its message. Since the string might contain a real key (if for instance the application had read the SDK key from configuration data that included a newline character, and neglected to trim the newline), exposing the value in an exception message that might end up in a log was a security risk. This has been changed so that the exception message only says the key contains an invalid character, but does not include the value. (The underlying exception behavior is part of the OkHttp library, so be aware that if you inject any custom headers with illegal characters into your HTTP configuration, their values might still be exposed in this way.)FileData
to clarify that you should not useoffline
mode in conjunction withFileData
; instead, you should just turn off events if you don't want events to be sent. Turning onoffline
mode will disableFileData
just as it disables all other data sources. (#235)