This repository has been archived by the owner on May 30, 2024. It is now read-only.
Pk/ms timeouts #15
Merged
Pk/ms timeouts #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an API breaking change, so we'd need to do a major release. Also the docs need to be updated. |
|
Yeah, that's right. I meant to mention that. |
|
Okay, these latest changes maintain backwards compatibility, and allow you to specify the timeouts in either seconds or milliseconds. This will be a minor release. |
|
lgtm |
drichelson
added a commit
that referenced
this pull request
Aug 11, 2017
Update okhttp-eventsource to latest. Wire in timeout to okhttp-eventsource
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also got circleci builds working