Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Dan Richelson committed Apr 11, 2017
1 parent fa2b366 commit a80e94c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/main/java/com/launchdarkly/client/EventProcessor.java
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ public void flush() {

private void postEvents(List<Event> events) {

String json = LDConfig.Gson.toJson(events);
String json = LDConfig.gson.toJson(events);
logger.debug("Posting " + events.size() + " event(s) to " + config.eventsURI + " with payload: " + json);

String content = LDConfig.Gson.toJson(events);
String content = LDConfig.gson.toJson(events);

Request request = config.getRequestBuilder(sdkKey)
.url(config.eventsURI.toString() + "/bulk")
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/launchdarkly/client/FeatureFlag.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ class FeatureFlag {
private final boolean deleted;

static FeatureFlag fromJson(String json) {
return LDConfig.Gson.fromJson(json, FeatureFlag.class);
return LDConfig.gson.fromJson(json, FeatureFlag.class);
}

static Map<String, FeatureFlag> fromJsonMap(String json) {
return LDConfig.Gson.fromJson(json, mapType);
return LDConfig.gson.fromJson(json, mapType);
}

FeatureFlag(String key, int version, boolean on, List<Prerequisite> prerequisites, String salt, List<Target> targets, List<Rule> rules, VariationOrRollout fallthrough, Integer offVariation, List<JsonElement> variations, boolean deleted) {
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/launchdarkly/client/LDConfig.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
*/
public final class LDConfig {
private static final Logger logger = LoggerFactory.getLogger(LDConfig.class);
static final Gson Gson = new Gson();
static final Gson gson = new Gson();

private static final URI DEFAULT_BASE_URI = URI.create("https://app.launchdarkly.com");
private static final URI DEFAULT_EVENTS_URI = URI.create("https://events.launchdarkly.com");
Expand Down Expand Up @@ -266,7 +266,7 @@ public Builder capacity(int capacity) {
* Set the host to use as an HTTP proxy for making connections to LaunchDarkly. If this is not set, but
* {@link #proxyPort(int)} is specified, this will default to <code>localhost</code>.
* <p>
* If neither {@link #proxyHost(String)} or {@link #proxyPort(int)} are specified,
* If neither {@link #proxyHost(String)} nor {@link #proxyPort(int)} are specified,
* a proxy will not be used, and {@link LDClient} will connect to LaunchDarkly directly.
* </p>
*
Expand Down

0 comments on commit a80e94c

Please sign in to comment.