Merge pull request #211 from launchdarkly/eb/ch71166/debug-stacktrace

Java SDK should only log exception stacktraces at debug level
launchdarkly · Apr 21, 2020 · a7e97b9 · a7e97b9
2 parents 868ef25 + 1ee6277
commit a7e97b9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/main/java/com/launchdarkly/client/DefaultEventProcessor.java b/src/main/java/com/launchdarkly/client/DefaultEventProcessor.java
@@ -530,7 +530,8 @@ private static void postJson(OkHttpClient httpClient, Headers headers, String js
         }
         break;
       } catch (IOException e) {
-        logger.warn("Unhandled exception in LaunchDarkly client when posting events to URL: " + request.url(), e);
+        logger.warn("Unhandled exception in LaunchDarkly client when posting events to URL: {} ({})", request.url(), e.toString());
+        logger.debug(e.toString(), e);
         continue;
       }
     }

diff --git a/src/main/java/com/launchdarkly/client/LDClient.java b/src/main/java/com/launchdarkly/client/LDClient.java
@@ -473,7 +473,8 @@ private static String getClientVersion() {
       String value = attr.getValue("Implementation-Version");
       return value;
     } catch (IOException e) {
-      logger.warn("Unable to determine LaunchDarkly client library version", e);
+      logger.warn("Unable to determine LaunchDarkly client library version: {}", e.toString());
+      logger.debug(e.toString(), e);
       return "Unknown";
     }
   }