This repository has been archived by the owner on May 30, 2024. It is now read-only.
fix ContextBuilder.copyFrom NPE #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base copyOnWrite*Attributes on respective objects nullability otherwise they will not be initialized causing NPE
driverpt
reviewed
Nov 9, 2023
| @@ -380,8 +380,8 @@ ContextBuilder copyFrom(LDContext context) { | |||
| anonymous = context.isAnonymous(); | |||
| attributes = context.attributes; | |||
| privateAttributes = context.privateAttributes; | |||
| copyOnWriteAttributes = true; | |||
| copyOnWritePrivateAttributes = true; | |||
| copyOnWriteAttributes = context.attributes != null; | |||
There was a problem hiding this comment.
Suggestion: Objects.nonNull(context.attributes)
|
@pedroafonsodias, thank you for bringing this to our attention. Could you provide steps/pseudocode for reproducing the NPE. |
Using springboot to create a default context and when reusing it to customize a new context it will fail unless we specify a dummy attribute when creating the initial I have added a test in the mean time. |
tanderson-ld
approved these changes
Nov 9, 2023
|
@pedroafonsodias, approved but going to take a bit more time making sure there are no adverse consequences that others may have already been accounting for in production. Thank you for your contribution! |
|
Any ETA when this is going to be released? |
|
Working on releasing today. |
Merged
LaunchDarklyReleaseBot
added a commit
that referenced
this pull request
Nov 13, 2023
## [2.1.1] - 2023-11-13 ### Fixed: - Fixes NPE when interacting with Context created by use of `copyFrom`. (Thanks, [ pedroafonsodias](#15)) --------- Co-authored-by: Pedro Dias <[email protected]> Co-authored-by: Todd Anderson <[email protected]>
|
@pedroafonsodias and @driverpt , what versions of the Java Server SDK are you using? |
|
5.10, very old versions. We detected this while upgrading to the latest version |
LaunchDarklyReleaseBot
added a commit
to launchdarkly/java-sdk-internal
that referenced
this pull request
Nov 14, 2023
## [1.2.1] - 2023-11-13 ### Fixed: - Fixes NPE when interacting with Context created by use of `copyFrom`. (Thanks, [ pedroafonsodias](launchdarkly/java-sdk-common#15)) --------- Co-authored-by: Eli Bishop <[email protected]> Co-authored-by: LaunchDarklyReleaseBot <[email protected]> Co-authored-by: Todd Anderson <[email protected]> Co-authored-by: tanderson-ld <[email protected]> Co-authored-by: ld-repository-standards[bot] <113625520+ld-repository-standards[bot]@users.noreply.github.com> Co-authored-by: Kane Parkinson <[email protected]> Co-authored-by: Ryan Lamb <[email protected]>
LaunchDarklyReleaseBot
added a commit
to launchdarkly/java-server-sdk
that referenced
this pull request
Nov 14, 2023
## [7.1.1] - 2023-11-14 ### Fixed: - Fixes NPE when interacting with Context created by copying. (Thanks, [ pedroafonsodias](launchdarkly/java-sdk-common#15)) --------- Co-authored-by: Eli Bishop <[email protected]> Co-authored-by: LaunchDarklyReleaseBot <[email protected]> Co-authored-by: Alex Engelberg <[email protected]> Co-authored-by: Anton Mostovoy <[email protected]> Co-authored-by: LaunchDarklyCI <[email protected]> Co-authored-by: LaunchDarklyCI <[email protected]> Co-authored-by: Gavin Whelan <[email protected]> Co-authored-by: ssrm <[email protected]> Co-authored-by: Harpo Roeder <[email protected]> Co-authored-by: Ben Woskow <[email protected]> Co-authored-by: Elliot <[email protected]> Co-authored-by: Robert J. Neal <[email protected]> Co-authored-by: Robert J. Neal <[email protected]> Co-authored-by: Sam Stokes <[email protected]> Co-authored-by: Ember Stevens <[email protected]> Co-authored-by: ember-stevens <[email protected]> Co-authored-by: Alex Engelberg <[email protected]> Co-authored-by: Louis Chan <[email protected]> Co-authored-by: Louis Chan <[email protected]> Co-authored-by: Todd Anderson <[email protected]> Co-authored-by: tanderson-ld <[email protected]> Co-authored-by: Matthew M. Keeler <[email protected]> Co-authored-by: ld-repository-standards[bot] <113625520+ld-repository-standards[bot]@users.noreply.github.com> Co-authored-by: Kane Parkinson <[email protected]> Co-authored-by: Ryan Lamb <[email protected]>
|
Should now be available in Java Server SDK 7.1.1. May still be propagating through package managers. |
tanderson-ld
added a commit
to launchdarkly/android-client-sdk
that referenced
this pull request
Mar 7, 2024
**Related issues** This fix never propagated into the Android SDK and another customer reported it. launchdarkly/java-sdk-common#15
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base
copyOnWrite*Attributeson respective objects nullability otherwise they will not be initialized causingNPE