This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
chore: Expect event sink to match predicate. #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
May 28, 2024
| @@ -148,9 +151,52 @@ public void ModifiedFileIsReloadedIfAutoUpdateIsOn() | |||
|
|
|||
| file.SetContentFromPath(TestUtils.TestFilePath("segment-only.json")); | |||
|
|
|||
| var newData = _updateSink.Inits.ExpectValue(TimeSpan.FromSeconds(5)); | |||
|
|
|||
| AssertJsonEqual(DataSetAsJson(ExpectedDataSetForSegmentOnlyFile(2)), DataSetAsJson(newData)); | |||
There was a problem hiding this comment.
Cannot just do a JSON comparison if the version number is going to be incremented every time a change is detected.
There was a problem hiding this comment.
This isn't pretty, but I want the test to stop failing.
|
This isn't the last flaky test. The contract tests fail sometimes, so I will sort that next in another PR. |
tanderson-ld
approved these changes
May 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mac the file data source receives extra file change notifications and fails intermittently. This adds an assert helper based on a predicate that allows checking multiple events.
This helper will likely need to be used on other tests as there are some similar intermittent failures with big segments.