This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
fix: fixes issue where first flag listener callback was not triggered… #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if active context is a multicontext
tanderson-ld
commented
Jun 4, 2024
| private readonly Context _otherUser = Context.New("other-key"); | ||
|
|
||
| private readonly Context _basicUser = Context.NewMulti(Context.New(ContextKind.Of("user"), "user-key1"), Context.New(ContextKind.Of("custom-kind"), "custom-key1")); | ||
| private readonly Context _otherUser = Context.NewMulti(Context.New(ContextKind.Of("user"), "user-key2"), Context.New(ContextKind.Of("custom-kind"), "custom-key2")); |
There was a problem hiding this comment.
For reviewers: Using multi-contexts in the test here causes the tests to fail without the fix, so this is sufficient test coverage now.
kinyoklion
approved these changes
Jun 4, 2024
kinyoklion
reviewed
Jun 4, 2024
kinyoklion
reviewed
Jun 4, 2024
kinyoklion
reviewed
Jun 4, 2024
tanderson-ld
pushed a commit
that referenced
this pull request
Jun 5, 2024
🤖 I have created a release *beep* *boop* --- ## [5.2.1](5.2.0...5.2.1) (2024-06-05) ### Bug Fixes * fixes issue where first flag listener callback was not triggered… ([#97](#97)) ([6bf8ec1](6bf8ec1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… if active context is a multicontext
Requirements
Related issues
#70
Describe the solution you've provided
Key should have been FullyQualifiedKey. This was a bug introduced during the users to context work.