This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
ci: fixing publish docs secrets issue #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #233251: Dotnet client release please. |
keelerm84
approved these changes
Feb 20, 2024
keelerm84
approved these changes
Feb 20, 2024
kinyoklion
approved these changes
Feb 20, 2024
kinyoklion
reviewed
Feb 20, 2024
| @@ -10,6 +10,12 @@ jobs: | |||
| contents: write # Needed in this case to write github pages. | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
|
|
|||
There was a problem hiding this comment.
Is the secret needed for the CI workflow? We may have problems when it comes to contributor PRs that cannot use secrets.
There was a problem hiding this comment.
Yes, in the current setup, the workflow files are the ones that set up the AWS role. When I went to trigger docs manually, realized I forgot it in this workflow.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.