Allow symlinks to be followed for migration files #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should add
to the issue description 🙂 |
|
Neat. Thanks for the fix. |
tgeoghegan
added a commit
to tgeoghegan/sqlx
that referenced
this pull request
Apr 5, 2023
When enumerating the source directory seeking migration files, `sqlx` ignores entries that aren't files. This was previously reported as launchbadge#614 and fixed in launchbadge#985 but apparently regressed somewhere along the way. This commit reintroduces the fix from launchbadge#985 to the current implementation: use `std::fs::metadata` instead of `std::fs::DirEntry::metadata`. The former is documented to traverse symlinks; the latter does not.
abonander
pushed a commit
that referenced
this pull request
Jun 13, 2023
* Traverse symlinks when resolving migrations When enumerating the source directory seeking migration files, `sqlx` ignores entries that aren't files. This was previously reported as #614 and fixed in #985 but apparently regressed somewhere along the way. This commit reintroduces the fix from #985 to the current implementation: use `std::fs::metadata` instead of `std::fs::DirEntry::metadata`. The former is documented to traverse symlinks; the latter does not. * add migrations_symlink test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entry.metadata() does not follow symlinks, while fs::metadata() does. This allows for greater compatibility with the bazel build system which uses symlinks for data files such as migrations.
Fixes #614