Fix for Postgres decimals #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really appreciate you digging into this. This is a bit out of my direct understanding so pinging some people that know it better than I. @pimeys and @abonander Can you take a look at this as you've looked at the decimals in here a bunch before? |
|
Thanks again ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See additional details #888
0.01conversions could've been easily fixed without rewriting the whole thing, there's just one edge case that needs to be handled (see 2nd commit).I couldn't find a standalone reproducer for the issue mentioned above, however, everything works fine with my branch.