Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite synchronous setting #850

Merged
merged 1 commit into from
Dec 19, 2020
Merged

sqlite synchronous setting #850

merged 1 commit into from
Dec 19, 2020

Conversation

markazmierczak
Copy link
Contributor

@markazmierczak markazmierczak commented Nov 23, 2020 •
edited
Loading

Add support for "synchronous" setting in SQLite connection options.
This makes changing this setting to NORMAL (from default FULL) easy.
The NORMAL mode is even advised by SQLite documentation (and that is understandable):

If durability is not a concern, then synchronous=NORMAL is normally all one needs in WAL mode.

@markazmierczak markazmierczak mentioned this pull request Nov 24, 2020
Closed
@mehcode
Copy link
Member

mehcode commented Dec 19, 2020

Looks great to me. Thank you for the name tweak. 🙌

@mehcode mehcode merged commit e584618 into launchbadge:master Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehcode mehcode Awaiting requested review from mehcode

Assignees
No one assigned
Labels
db:sqlite Related to SQLite waiting for author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markazmierczak @mehcode