Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #740

Merged
merged 3 commits into from
Oct 16, 2020
Merged

Cleanup #740

merged 3 commits into from
Oct 16, 2020

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Oct 14, 2020

A few small things from #735 to make sure none of this is what makes CI fail.

* async_native_tls::Error is the same as native_tls::Error
* tokio_native_tls is also used for actix (was in the wrong section)
* Move negated runtime feature checks to the end for consistency
* Remove redundant cfg attribute
@jyn514
Copy link
Contributor

jyn514 commented Oct 14, 2020

Thanks, these warnings were bugging me.

@jplatte
Copy link
Contributor Author

jplatte commented Oct 15, 2020

It's not all of them unfortunately. The other ones were not as easy to fix so I skipped them for now.

@abonander abonander merged commit 96609d4 into launchbadge:master Oct 16, 2020
@abonander
Copy link
Collaborator

Thanks! Hopefully this fixes some other PRs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants