Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pgsql cube type compile fail #3459

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

kdesjard
Copy link
Contributor

@kdesjard kdesjard commented Aug 24, 2024

Does your PR solve an issue?

Resolves #3461
Resolves #3460
Replaces #3457
Replaces #3456

The Postgresql cube type fails to compile in version 0.8.1:

.../sqlx-postgres-0.8.1/src/types/cube.rs:307:33
    |
307 |     const PACKED_WIDTH: usize = size_of::<u32>();
    |                                 ^^^^^^^ not found in this scope
    |
help: consider importing one of these items
    |
1   + use core::mem::size_of;
    |
1   + use std::mem::size_of;

The PR includes a patch for this as well as a scoping change for the hstore type to keep it consistent with the others.

@CommanderStorm
Copy link
Contributor

CommanderStorm commented Aug 24, 2024

Could you add the following to your PR-description? (this way, other users have a link to follow)

Resolves #3461
Resolves #3460
Replaces #3457
Replaces #3456

@abonander
Copy link
Collaborator

@kdesjard cargo fmt needs to be run.

@imor
Copy link

imor commented Aug 26, 2024

@kdesjard could you please run cargo fmt and push a commit. Without this fix pg_replicate's MSRV needs to be bumped which we'd like to avoid.

@kdesjard
Copy link
Contributor Author

I did push a commit f47ce6b

Am I missing something?

@abonander abonander merged commit 371cf4a into launchbadge:main Aug 26, 2024
79 checks passed
jrasanen pushed a commit to jrasanen/sqlx that referenced this pull request Oct 14, 2024
* fails to compile as size_of is not found in scope

* keep scoping consistent with other type modules

* fmt fixes

---------

Co-authored-by: kdesjard <[email protected]>
jrasanen pushed a commit to jrasanen/sqlx that referenced this pull request Oct 14, 2024
* fails to compile as size_of is not found in scope

* keep scoping consistent with other type modules

* fmt fixes

---------

Co-authored-by: kdesjard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants