Fix (#3395) sqlx::test macro in 0.8 #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joeydewaal do you mind adding a regression test so we can catch if this happens in the future? |
|
Not sure what the best way is to add a test for a proc macro, but this should work! |
|
I should have mentioned there's already existing test files, one for each supported database: |
|
It looks like there was a test for mysql that should've caught this. I added a test for postgres and sqlite. |
|
@joeydewaal run |
|
Yes of course! |
abonander
approved these changes
Aug 7, 2024
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
* fix: fixture macro attribute * remove extra new line * add extra new line * feat: add test for slqx::test macro * feat: update test for sqlx::test macro * remove old macro test * feat: add postgres and sqlite test * rust format * cargo fmt * fix fixtures execution order in test
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
* fix: fixture macro attribute * remove extra new line * add extra new line * feat: add test for slqx::test macro * feat: update test for sqlx::test macro * remove old macro test * feat: add postgres and sqlite test * rust format * cargo fmt * fix fixtures execution order in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
This fixes a regression in the
sqlx::testmacro in version 0.8.Fixes: #3395