Pass the persistent query setting when preparing queries with the Any driver
#3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etorreborre
force-pushed
the
etorreborre/persistent-queries-any
branch
from
ac1d8a1 to
24db70e
Compare
Why? This is just a pessimization for queries that don't use arguments. |
Just to be consistent with the existing code because I wasn't sure about the current differences. I'll change that. |
etorreborre
force-pushed
the
etorreborre/persistent-queries-any
branch
from
24db70e to
b96d735
Compare
|
@abonander please check the latest commit. |
etorreborre
force-pushed
the
etorreborre/persistent-queries-any
branch
from
b96d735 to
447ac4a
Compare
|
@abonander I have now rebased on |
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR passes the
query.persistent()value to thefetch_manyandfetch_optionalfunction so that they can use it to cache prepared queries.Note I have kept the existing logic for the SQLite driver where persisting queries requires both the persistent flag and the existence of arguments.