Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #[derive(sqlx::Type)] in Postgres #3252

Merged
merged 6 commits into from
Jun 15, 2024
Merged

fix #[derive(sqlx::Type)] in Postgres #3252

merged 6 commits into from
Jun 15, 2024

Conversation

abonander
Copy link
Collaborator

@abonander abonander commented May 31, 2024 •
edited
Loading

  • Properly resolve schema-qualified type names
  • Emit PgHasArrayType impls for enums.

Breaking changes:

  • Manual implementations of PgHasArrayType for enums will conflict with the generated one. Delete the manual impl or add #[sqlx(no_pg_array)] below #[derive(sqlx::Type)]
  • Type equality for PgTypeInfo is now schema-aware.

@abonander abonander added db:postgres Related to PostgreSQL macros breaking labels May 31, 2024
@abonander abonander merged commit 2618439 into main Jun 15, 2024
4 checks passed
@abonander abonander deleted the ab/fix-enums branch June 15, 2024 18:57
This was referenced Jun 15, 2024
Closed
Closed
Closed
Closed
Closed
@Diggsey Diggsey mentioned this pull request Aug 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking db:postgres Related to PostgreSQL macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abonander