fix: get_filename should not consume self #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
requested changes
May 14, 2024
jasonish
force-pushed
the
fix/get_filename/v1
branch
from
3cb257c
to
babbc9e
Compare
|
The build failure is not relevant, it's a side-effect of us using |
|
@jasonish if you rebase, it should fix the build failure. |
jasonish
force-pushed
the
fix/get_filename/v1
branch
from
babbc9e
to
f077d8b
Compare
jayy-lmao
pushed a commit
to jayy-lmao/sqlx
that referenced
this pull request
Jun 6, 2024
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Make
get_filenameusable? Unless I was missing how to use it.