Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres) : int type conversion while decoding #3173

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

RaghavRox
Copy link
Contributor

Does your PR solve an issue?

Fixes #3161

@RaghavRox
Copy link
Contributor Author

@abonander can I get a review on this PR.

sqlx-postgres/src/types/int.rs Show resolved Hide resolved
Copy link
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to request changes, not approve (see above)

@RaghavRox RaghavRox force-pushed the 3161 branch 2 times, most recently from 7d19d0c to 6556325 Compare April 5, 2024 06:51
@RaghavRox RaghavRox requested a review from abonander April 5, 2024 07:01
sqlx-postgres/src/types/int.rs Outdated Show resolved Hide resolved
@abonander abonander merged commit e42ee35 into launchbadge:main Apr 19, 2024
62 checks passed
jayy-lmao pushed a commit to jayy-lmao/sqlx that referenced this pull request Jun 6, 2024
* fix(postgres) : int type conversion while decoding

* Check value buffer len when decoding integer type in postgres

* decode from octal for postgres i8

---------

Co-authored-by: RaghavRox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using : i32 for INT8 values in postgres results in the least significant 4 bytes being silently ignored
3 participants