SqliteConnectOptions::filename() memory fix (#3136) #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
requested changes
Mar 30, 2024
There was a problem hiding this comment.
This will erase the in_memory flag if the filename is not :memory: but that would break usage of in-memory databases with shared cache (see the description of the SQLITE_OPEN_MEMORY flag): https://www.sqlite.org/c3ref/open.html
Additionally, the docs for filename() need to be updated to describe the new behavior.
|
@hoxxep are you planning on addressing my review comment? |
|
@abonander apologies for the delay. I have pushed an alternative proposal to align with your comments, which is to allow setting the |
jayy-lmao
pushed a commit
to jayy-lmao/sqlx
that referenced
this pull request
Jun 6, 2024
…hbadge#3137) * SqliteConnectOptions::filename() memory fix (launchbadge#3136) * Expose in_memory sqlite option * Docs SqliteConnectOptions::filename include mention of from_str alternative * Docs SqliteConnectOptions::filename typo fix
2 tasks
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
…hbadge#3137) * SqliteConnectOptions::filename() memory fix (launchbadge#3136) * Expose in_memory sqlite option * Docs SqliteConnectOptions::filename include mention of from_str alternative * Docs SqliteConnectOptions::filename typo fix
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
…hbadge#3137) * SqliteConnectOptions::filename() memory fix (launchbadge#3136) * Expose in_memory sqlite option * Docs SqliteConnectOptions::filename include mention of from_str alternative * Docs SqliteConnectOptions::filename typo fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3136