fix: Make rust_decimal and bigdecimal decoding more lenient #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronbraid
added a commit
to cameronbraid/readyset_seaorm_issues
that referenced
this pull request
Aug 9, 2023
cameronbraid
added a commit
to cameronbraid/readyset_seaorm_issues
that referenced
this pull request
Aug 10, 2023
PR launchbadge/sqlx#2688 split has_decimal binaries into separate files add view_type table which contains a bool column which causes issues
|
@cameronbraid what is the status of this PR? |
|
@abonander I don't know. I hope someone will review it and merge it. |
|
@cameronbraid the commit message suggests that you were still working on the problem. If you rebase it should clear the CI error. |
fixes readysettech/readyset#143 When using readyset as a caching proxy - readyset returns a decimal with the following type info `MySqlTypeInfo { type: Decimal, flags: ColumnFlags(0x0), char_set: 33, max_size: Some(1024) }` Currently rust_decimal and bigdecimal expect an exact match for the type info `MySqlTypeInfo { type: NewDecimal, flags: ColumnFlags(BINARY), char_set: 63, max_size: None }` Therefore the following error occurs when readyset sends a valid decimal type ``` error occurred while decoding column "price": mismatched types; Rust type `core::option::Option<rust_decimal::decimal::Decimal>` (as SQL type `DECIMAL`) is not compatible with SQL type `DECIMAL` ``` This patch makes the `Type<MySql> for Decimal` more lenient by matching `MySqlTypeInfo` that has ColumType::Decimal | ColumnType::NewDecimal to be parsed by both rust_decimal and bigdecimal types
cameronbraid
force-pushed
the
decimal_compatibility_lenient
branch
from
dcbc6e8
to
11e2e28
Compare
|
@abonander thanks, I have done the rebase. Lets see where that takes us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes readysettech/readyset#143
When using readyset as a caching proxy - readyset returns a decimal with the following type info
MySqlTypeInfo { type: Decimal, flags: ColumnFlags(0x0), char_set: 33, max_size: Some(1024) }Currently rust_decimal and bigdecimal expect an exact match for the type info
MySqlTypeInfo { type: NewDecimal, flags: ColumnFlags(BINARY), char_set: 63, max_size: None }Therefore the following error occurs when readyset sends a valid decimal type
This patch makes the
Type<MySql> for Decimalmore lenient by matchingMySqlTypeInfothat has ColumType::Decimal | ColumnType::NewDecimal to be parsed by both rust_decimal and bigdecimal types