Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Clone for PoolOptions manually (#2548) #2553

Merged
merged 3 commits into from
Jul 9, 2023
Merged

Implement Clone for PoolOptions manually (#2548) #2553

merged 3 commits into from
Jul 9, 2023

Commits on Jun 18, 2023

  1. Implement Clone for PoolOptions manually (#2548)

    Trying to derive `Clone` automatically for `PoolOptions` results
    in errors when `clone` is actually called. This is because the
    derive incorrectly determines that `Clone` is _not_ derivable
    due to the lack of `Clone` implementation on the `DB: Database`
    type parameter, even though no value of that type is actually
    stored in a to-be-cloned position (in fact, it's only used for
    the `Connection` associated type on the type parameter's
    `Database` trait impl).
    
    Manually implementing `Clone` side-steps this issue and insures
    the type is always actually cloneable.
    
    For reference: #2548
    alilleybrinker committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    b24d40a View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. Ran 'cargo fmt'

    alilleybrinker committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    eb27643 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2023

  1. Configuration menu
    Copy the full SHA
    05dc665 View commit details
    Browse the repository at this point in the history