Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): example of sqlx_macros_unstable in config.toml #2400

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

df51d
Copy link
Contributor

@df51d df51d commented Mar 12, 2023

RUSTFLAGS space separates the arguments, so we actually have to combine them with an equal sign

@abonander
Copy link
Collaborator

Did you actually test this change? It should be passed as a single argument string to the rustc command regardless.

@df51d
Copy link
Contributor Author

df51d commented Mar 14, 2023

Did you actually test this change? It should be passed as a single argument string to the rustc command regardless.

Yes, I tested it. When my config.toml looks like this

[build]
rustflags = ["--cfg sqlx_macros_unstable"]

I am getting this error:

$ cargo build

error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `rustc - --crate-name ___ --print=file-names '--cfg sqlx_macros_unstable' --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-t
ype staticlib --crate-type proc-macro --print=sysroot --print=split-debuginfo --print=crate-name --print=cfg` (exit status: 1)
  --- stderr
  error: Unrecognized option: 'cfg sqlx_macros_unstable'

For me this only works when I replace with =.

@abonander abonander merged commit a61bb0c into launchbadge:release/0.7.0-alpha.2 Mar 14, 2023
@df51d df51d deleted the patch-1 branch March 14, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants