Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode username on read #214

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Decode username on read #214

merged 1 commit into from
Apr 1, 2020

Conversation

jamwaffles
Copy link
Contributor

Decodes connection string URL component so usernames with @ symbols in them are handled properly.

Closes #152

mehcode
mehcode requested changes Mar 31, 2020
View reviewed changes
sqlx-core/src/mysql/connection.rs Outdated Show resolved Hide resolved
@jamwaffles jamwaffles requested a review from mehcode March 31, 2020 22:05
@mehcode mehcode merged commit 3a997f0 into launchbadge:master Apr 1, 2020
mehcode added a commit that referenced this pull request Apr 1, 2020
@mehcode
use cow::borrowed to remove a minor allocation in postgres/startup
2a9774d 
refs #214
@mehcode
Copy link
Member

mehcode commented Apr 1, 2020

@jamwaffles Check 2a9774d when you have a moment. I had to change .as_str() to .as_ref().

Thanks for the contribution!

@jamwaffles
Copy link
Contributor Author

Ah, so that's the magic method call 😁. This is my first encounter with Cow so thanks for bearing with me. Is there a timeline on release for this feature by the way?

@mehcode
Copy link
Member

mehcode commented Apr 2, 2020

Now sounds about good. 😄

@jamwaffles
Copy link
Contributor Author

Awesome! Thank you for being super quick with this! Really appreciate it :)

@frigus02 frigus02 mentioned this pull request Aug 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehcode mehcode Awaiting requested review from mehcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usernames should be percent encoded.
2 participants
@jamwaffles @mehcode