Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqlite EXPLAIN type inference improvements #1984

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Sqlite EXPLAIN type inference improvements #1984

merged 3 commits into from
Sep 21, 2022

Conversation

rongcuid
Copy link
Contributor

Fixes #1983.

  • No longer complains about ROW_NUMBER type being null
  • Supports all window functions that returns integer

Feel free to merge if repo maintainer thinks this is a good first step.

@rongcuid
Copy link
Contributor Author

I think I have all the aggregates described here: https://www.sqlite.org/windowfunctions.html#introduction_to_window_functions

I am not using them, so I am not testing those.

@rongcuid
Copy link
Contributor Author

What does it mean by failing to format? I don't see any output in the checks.

@abonander
Copy link
Collaborator

https://github.com/launchbadge/sqlx/runs/7438234746?check_suite_focus=true

Just run cargo fmt and commit.

@rongcuid
Copy link
Contributor Author

Can someone check and merge this? I have another PR I want to submit later.

@abonander
Copy link
Collaborator

Changes to null inference are potentially a breaking change and so this will need to wait for 0.7.0.

@abonander abonander added this to the 0.7.0 milestone Sep 13, 2022
@abonander abonander changed the base branch from main to 0.7-dev September 15, 2022 00:36
@abonander
Copy link
Collaborator

PR target changed to the 0.7 development branch.

@abonander
Copy link
Collaborator

@rongcuid can you push another commit to trigger another CI run? Amending and force-pushing your last commit to update the SHA should be sufficient. I'm now working on 0.7.0 so this will be merged soon.

@rongcuid
Copy link
Contributor Author

What's going on? How do I make it pass?

@abonander
Copy link
Collaborator

If you rebase on 0.7-dev it should fix those.

@abonander abonander merged commit 0e708b6 into launchbadge:0.7-dev Sep 21, 2022
abonander pushed a commit that referenced this pull request Feb 18, 2023
@rongcuid @abonander
Sqlite EXPLAIN type inference improvements (#1984)
86dcb11 
* AggValue and ROW_NUMBER()

* Some more functions

* cargo fmt
abonander pushed a commit that referenced this pull request Feb 21, 2023
@rongcuid @abonander
Sqlite EXPLAIN type inference improvements (#1984)
3cb8e07 
* AggValue and ROW_NUMBER()

* Some more functions

* cargo fmt
Aandreba pushed a commit to Aandreba/sqlx that referenced this pull request Mar 31, 2023
@rongcuid @Aandreba
Sqlite EXPLAIN type inference improvements (launchbadge#1984)
e021663 
* AggValue and ROW_NUMBER()

* Some more functions

* cargo fmt
@raviqqe raviqqe mentioned this pull request Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

SQLite ROW_NUMBER incorrect type inference in explain
2 participants
@rongcuid @abonander