feat(postgres): make extra_float_digits settable
#1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
force-pushed
the
ab/extra_float_digits
branch
from
b9f01c6
to
16f457e
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1074
addresses #801 (comment)
I didn't really want to spend much time figuring out what version string Redshift returns, and according to the comment on #801 above, even certain versions of Postgres 10 don't support the
extra_float_digitsoption, so that just generally sounded like a rabbit hole I didn't want to go down.Supercedes #1746 (I wanted to editoralize the documentation on the method and also make it take
Optionand that point it was just easier to open a new PR rather than try to adjust that one)